Waveform playback filter in playback_filters.md: Peak option missing

bavc / qctools

QCTools (Quality Control Tools for Video Preservation) is a free and open source software tool that helps users analyze and understand their digitized video files through use of audiovisual analytics and filtering. QCTools is funded by the National Endowment for the Humanities and the Knight Foundation, and is developed by the Bay Area Video Coalition.

http://www.bavc.org/qctools

Other

317 stars 41 forks source link

Waveform playback filter in playback_filters.md: Peak option missing #332

Closed lbjohnson01 closed 7 years ago

lbjohnson01 commented 7 years ago

Copy reads:

Peak: If enabled, the vectorscope will outline the extent of the plotted values to show an envelope around the plotted values. Peak may be adjusted to outline the extent frame-per-frame or over time.

I'm not seeing an option for Peak. Should this bullet point be removed? waveform-peak-option-not-showing

ablwr commented 7 years ago

If it's gone, it must be gone, but I don't know. @dericed did you remove/adjust?

dericed commented 7 years ago

Good catch. I removed peak in https://github.com/bavc/qctools/commit/c2785b90aa32f76378f01e4423408f9849147cf0 and replaced it with a method to adjust the scale used to label the graticule.

FFmpeg's doc on that is sparse:

  scale             <int>        ..FV.... set scale (from 0 to 2) (default digital)
     digital                      ..FV....
     millivolts                   ..FV....
     ire                          ..FV....

ablwr commented 7 years ago

Will resolve in https://github.com/bavc/qctools/pull/338/commits/49ec9411d922a52170f0706a46a4a2e9f0ff2680

dericed commented 7 years ago

https://github.com/bavc/qctools/pull/338/commits/49ec9411d922a52170f0706a46a4a2e9f0ff2680 is merged so closing