search

bavc / signalserver

MIT License
19 stars 6 forks source link

Readme updates #264

Closed dericed closed 7 years ago

dericed commented 7 years ago

These 3 commits by were pushed directly to master. I rebased master and moved the commits to this PR to allow for review.

dericed commented 7 years ago

Commits 3938f6b and 520c914 null each other out (one is a change and then a revert to the change), so I dropped both commits and left the third.

JeromeMartinez commented 7 years ago

Commits should be merged in one before merge (edit: done)

signalserver or SignalServer? signalserver or signal server / Signal Server? After these commits, there are "signalserver" (first word), "SignalServer" (second word just after the first word), "signal server", "Signal Server", and also "Signalsever", I suggest to decide about a form before changing it to different forms in a commit. "Signalserver" when first word in a sentence, there is some debate about uppercase 1st letter for a proper name having no uppercase 1st letter, should it be with uppercase 1st letter or not? Good question...

JeromeMartinez commented 7 years ago

Commit message does not make sense.

dericed commented 7 years ago

closing without merge