bavison / arm-mem

ARM-accelerated versions of selected functions from <string.h>
55 stars 13 forks source link

valgrind trouble / deprecated SETEND instructions #6

Closed rsaxvc closed 7 years ago

rsaxvc commented 7 years ago

Valgrind crashes during memcmp() due to the presence (really lack of implementation in Valgrind) of SETEND. ARM has deprecated these instructions, though they're still available in A32 and T32.

This pull request: https://github.com/bavison/arm-mem/pull/5 Removes the SETEND instructions and replaces them with REV instructions, which I expect to be a few cycles slower, but work with valgrind.

bavison commented 7 years ago

PR merged, thanks