search

bavix / laravel-wallet

It's easy to work with a virtual wallet
https://bavix.github.io/laravel-wallet/
MIT License
1.14k stars 230 forks source link

bug: DB::rollBack(0) in nova action prevents actionable trait to works #569

Closed ibrunotome closed 2 years ago

ibrunotome commented 2 years ago

Describe the bug There is a Actionable trait that logs all actions that ran before

https://nova.laravel.com/docs/4.0/actions/defining-actions.html#action-log

Screen Shot 2022-09-13 at 11 48 40

But using the solution https://bavix.github.io/laravel-wallet/#/nova-action, these action logs will not be recorded

Server:

rez1dent3 commented 2 years ago

@ibrunotome Thank you. I have never used this functionality. In the near future we will have to see what can be done there. At the moment, there are no ideas.

rez1dent3 commented 2 years ago

@ibrunotome Hello. Taylor accepted my PR and soon I will try to solve this problem and completely abandon my own DatabaseServiceInterface in favor of a standard solution.

But there will definitely not be a release in the near future, because. the changes are too big and you need to make sure that it works correctly.

Now you can take the event-architecture branch and see if your problem is gone.

PS. Changes to illuminate/database are still without a tag, so Laravel must be installed with the 9.x branch...

rez1dent3 commented 2 years ago

@ibrunotome Hello. Tag 9.6.0.

ibrunotome commented 2 years ago

You're a great developer @rez1dent3, thank you for always being improving this package.