search

bavovanachte / sphinx-wavedrom

A sphinx extension that allows including wavedrom diagrams by using its text-based representation
MIT License
34 stars 18 forks source link

Add initial support for the wavedrom-cli #27

Closed bradleyharden closed 4 years ago

bradleyharden commented 4 years ago

Sorry for the delay on #23. You called it. I'm swamped at the moment. This was a side-project of a side-project for me, so it's really low priority.

Here's what I have so far. It worked, but I remember wanting to do some error checking. I also remember thinking that one of the functions could use some refactoring to reduce redundancy.

If I remember right, there were three different possible sources for the data, but they all came in different formats. I didn't see any easy way to both make the code pretty and reduce the work done to an absolute minimum (for speed). I'll leave that to you. Let me know if you have any questions.

bavovanachte commented 4 years ago

I actually started working already on a separate PR in the meantime (couldn't help myself): #26 . I really appreciate the input, and I'll probably borrow some ideas (I like the NamedTemporaryFile), but I'll continue working on the other branch instead. I'll close this one to keep things neat.

bradleyharden commented 4 years ago

Sorry I couldn't offer something more complete.