bavovanachte / sphinx-wavedrom

A sphinx extension that allows including wavedrom diagrams by using its text-based representation
MIT License
32 stars 18 forks source link

Add confluence builder #47

Closed newAM closed 10 months ago

newAM commented 1 year ago

This allows this extension to work with sphinx-contrib/confluencebuilder

bavovanachte commented 1 year ago

That's an easy fix, thanks! 👍 Could this be tested in github actions somehow as well? These tests don't actually check the output, but allow to find warnings/errors when using the plugin.

newAM commented 1 year ago

Done! I didn't update the makefile since that appears to be auto-generated content? sphinx-build does the same thing in terms of test coverage, figured that would be preferable here.

I also added language = "en" since a lot of builds were failing with language = None.

bavovanachte commented 10 months ago

Nicely done, apologies for huge delay.