Deprecate Process.nice in favor of get_nice() and set_nice()

baweaver / psutil

Automatically exported from code.google.com/p/psutil

Other

0 stars 0 forks source link

Deprecate Process.nice in favor of get_nice() and set_nice() #290

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Making Process.nice a property able to both get and set process niceness was a 
poor decision mainly for two reasons:

- it is kind of ambiguous and less explicit compared to two separate get_nice 
and set_nice methods

- we already have get_ionice/set_ionice and get_cpu_priority/set_cpu_priority

My idea is to deprecate Process.nice in 0.5.0, turn it into an alias for 
get_nice and set_nice and completely remove it for 1.0.0 or later.

Original issue reported on code.google.com by g.rodola on 26 Jun 2012 at 6:19

GoogleCodeExporter commented 8 years ago

Makes sense to me for nice to have an explicit "set" method rather than being 
set as a property. This is probably one of those things where it's better to be 
clearer rather than more concise.

Original comment by jlo...@gmail.com on 26 Jun 2012 at 6:23

GoogleCodeExporter commented 8 years ago

Done in r1370.

Original comment by g.rodola on 26 Jun 2012 at 6:42

Changed state: FixedInSVN

GoogleCodeExporter commented 8 years ago

0.5.0 is finally out. Closing out as fixed.

Original comment by g.rodola on 27 Jun 2012 at 6:54

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

[deleted comment]

GoogleCodeExporter commented 8 years ago

Updated csets after the SVN -> Mercurial migration:
r1370 == revision ed8334ed04ad

Original comment by g.rodola on 2 Mar 2013 at 12:09