search

baxtree / subaligner

Automatically synchronize and translate subtitles, or create new ones by transcribing, using pre-trained DNNs, Forced Alignments and Transformers. https://subaligner.readthedocs.io/
https://hub.docker.com/r/baxtree/subaligner
MIT License
437 stars 18 forks source link

Read the entire subtitle file in when determing the encoding #50

Closed JohnVillalovos closed 3 years ago

JohnVillalovos commented 3 years ago

Previously only 10 lines were read and this could cause issues as Unicode characters may only appear after 10 lines and then a failure would occur.

codecov-io commented 3 years ago

Codecov Report

Merging #50 (41bd00b) into master (d4541b5) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          12       12           
  Lines        1894     1894           
=======================================
  Hits         1781     1781           
  Misses        113      113
Impacted Files Coverage Δ
subaligner/utils.py 96.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4541b5...41bd00b. Read the comment docs.

baxtree commented 3 years ago

Thanks for the PR， @JohnVillalovos. Btw, a similar fix was merged into the development branch (10 days ago) and can be brought in via upgrading to 0.1.1.post1.

JohnVillalovos commented 3 years ago

Thanks for the PR， @JohnVillalovos. Btw, a similar fix was merged into the development branch (10 days ago) and can be brought in via upgrading to 0.1.1.post1.

Oh great. Thank you!