search

bayandin / awesome-awesomeness

A curated list of awesome awesomeness
32.05k stars 3.55k forks source link

Auto-Reviews #267

Closed m1guelpf closed 7 years ago

m1guelpf commented 7 years ago

Now that this is alive again, I suggest to add automatic PR revision via TravisCI. We would use Awesome-Bot to check the links and Danger to check PR format and report back. As, for example, awesome-pentester, github-cheat-sheet, awesome-react, awesome-php... The only thing I need to start is that @bayandin enables TravisCI in this repository. What do you think? ping @bayandin @assp1r1n3 @KleoPetroff

assp1r1n3 commented 7 years ago

What will the procedure be for the broken links?

m1guelpf commented 7 years ago

@assp1r1n3 A bot will autopost a chart with the broken links

m1guelpf commented 7 years ago

Example output (from awesome-pentester):

2 Errors
:no_entry_sign: Please provide a summary in the Pull Request description
:no_entry_sign: Found 9 link issues

Link issues

Line Status Link
69 Dupe https://www.netsparker.com/
70 Dupe https://www.rapid7.com/products/nexpose/
71 Dupe http://www.tenable.com/products/nessus-vulnerability-scanner
72 Dupe https://cirt.net/nikto2
73 Dupe http://www.openvas.org/
74 Dupe https://www.owasp.org/index.php/OWASP_Zed_Attack_Proxy_Project
75 Dupe https://secapps.com/
77 Dupe http://wapiti.sourceforge.net/
78 Dupe http://www.webreaver.com/
assp1r1n3 commented 7 years ago

@m1guelpf I mean if the bot (after we will set it up in this repo) finds out that the link is broken, shall we delete that link immediately from the repo?

m1guelpf commented 7 years ago

@assp1r1n3 We can make it tell the user to fix it, and assing a "Broken link" flag, for example

KleoPetroff commented 7 years ago

I was thinking of something similar, so I'm totally in for this. Also the output is easy to understand, so fixing the erros should be pretty straightforward.

m1guelpf commented 7 years ago

@bayandin what do you think?

bayandin commented 7 years ago

Sounds cool, I think everything that can be automated should be automated.

m1guelpf commented 7 years ago

@bayandin Then open Travis CI, add the repo and add me as collaborator (so I can set it up)

bayandin commented 7 years ago

I've enabled Travis for this repo. You can set it up via .travis.yml.

m1guelpf commented 7 years ago

We've now auto-reviews!! Feel free to test them by making ramdom PR's Also, to make this work better, you should add @checkbot to the repo ping @assp1r1n3 @KleoPetroff @bayandin

checkbot commented 7 years ago

As @m1guelpf said, you have to add me for making this work. Automated response 👍

bayandin commented 7 years ago

Added

m1guelpf commented 7 years ago

So, @checkbot , fix #267