search

bayareawebpro / nova-field-ckeditor

Laravel Nova - CkEditor v5 Field - Media, Links & Snippet Browsers (VueJS)
MIT License
15 stars 10 forks source link

Nova 4 Support #10

Closed bashgeek closed 2 years ago

bashgeek commented 2 years ago

Nova in version 4 was released last week. Any chance we will see support for this in the near future? :-)

Anything we can do to help?

Thanks!

bayareawebpro commented 2 years ago

I started a new nova-v4 branch but there's a lot of issues that need to be addressed. I don't have an ETA at this time.

I have things partially working, but need to fix some core functionality and provide new css layouts for the modals etc.

I'll update this issue when I have it fully working, I could use some help with CSS at that point if you're interested.

rebeccaatwaxeye commented 2 years ago

@bayareawebpro I have "butchered" a forked version that has the core editor working in nova 4, I haven't yet had time to tackle the modals but hopefully it can be helpful?. https://github.com/rebeccaatwaxeye/nova-field-ckeditor/tree/nova-v4

bayareawebpro commented 2 years ago

@rebeccaatwaxeye Great thanks, will take a look.

pindab0ter commented 2 years ago

I can confirm that basic functionality is working on the nova-v4-branch as of now. The only thing that I'm noticing at first glance is that the editor field doesn't have dark mode support yet.

bayareawebpro commented 2 years ago

After some lengthy discussions we've decided to move away from Nova in favor of a custom solution.

This repository will be eventually archived in a few months, feel free to fork it and maintain your own version if you would like to continue using it.

The master branch is a self contained build, but only works for Nova3 / Vue2.

The dev branch (mostly working, some style issues, Nova4 / Vue3) depends on an NPM package @bayareawebpro/ckeditor5-classic-custom, which should also be forked to customize the editor build.