bayasdev / envycontrol

Easy GPU switching for Nvidia Optimus laptops under Linux
https://bayas.dev/envycontrol
MIT License
1.18k stars 60 forks source link

[REQUEST] Ask if the user wants to backup xorg.conf or do it automatically and revert it on cleanup #108

Open StitiFatah opened 1 year ago

StitiFatah commented 1 year ago

Is your feature request related to a problem? Please describe.

Had glitches issues on i3, sddm zoomed, picom behaving weirdly, using the reset option didn't fix anything, I had a hard time figuring out it was because the script had overwritten my xorg.conf, initially thought it was an nvidia problem, then was about to reinstall X

Actually exept for Xsetup the reset functionality just removes the auto generated files, imo it thus doesn't really "Revert changes made by EnvyControl" .

Describe the solution you'd like

Before overwriting xorg.conf the script should rename xorg.conf to before_envy_xorg.conf (I already had a backup of xorg.conf so a generic name may have overwritten it) and then on --reset when calling the cleanup function it should rename it to xorg.conf in addition to removing the generated one

Dani3I commented 1 year ago

This post is actually answer to my worries. That is because "Readme" says:

Keep in mind any custom X.org configuration may get deleted or overwritten when switching modes.

But at the same time there is:

--reset Revert changes made by EnvyControl

So I was wondering if "--reset" also reverts custom xorg configurations. I don't know much about this so I was wondering how to backup my xorg configuration (because I don't know which files could be deleted or overwritten or modified by envycontrol) (and also if xorg configuration "provided" by my distro even is custom in any way). So I think that it would be nice if every modified/overwritten/deleted file had a backup so I would be able to install envycontrol, try how it works, and just reset everything to a state it was before installing envycontrol if needed.

bayasdev commented 1 year ago

So I was wondering if "--reset" also reverts custom xorg configurations.

Currently we don't backup custom Xorg configs, however you can run envy control on verbose mode to log all the changes made on your system.

Regards.