search

bayes-rules / bayesrules

📦 R package for Supplemental Materials for the Bayes Rules! Book
https://bayes-rules.github.io/bayesrules/docs/
GNU General Public License v3.0
70 stars 10 forks source link

fix _cv dependencies on groupdata2 package #77

Closed ajohns24 closed 3 years ago

ajohns24 commented 3 years ago

For hierarchical models, the _cv functions depend upon the fold() function from groupdata2. I have that in the import line of the R file, but it's not being recognized.

ajohns24 commented 3 years ago

This still isn't running with the code in Chapter 17. The error message:

Error in check_fold_once(data = data, k = k, cat_col = cat_col, num_col = num_col, : could not find function "check_fold_once"

check_fold_once() should be defined by fold()

mdogucu commented 3 years ago

What code is this error associated with? prediction_summary_cv()?

ajohns24 commented 3 years ago

Yes. And classification_summary_cv.

On Mon, Jun 7, 2021 at 3:49 PM Mine Dogucu @.***> wrote:

What code is this error associated with? prediction_summary_cv()?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mdogucu/bayesrules/issues/77#issuecomment-856247464, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDOVORVNDH5ROJ4JKD6N2TTRUWF7ANCNFSM46HZJ5FQ .

-- Alicia Johnson she/her Associate Professor Mathematics, Statistics, and Computer Science Macalester College

mdogucu commented 3 years ago

I am not getting any errors with prediction_summary_cv()?. I will look intoclassification_summary_cv()`

ajohns24 commented 3 years ago

Have you tried it with the hierarchical model in Chapter 17? (The code is shown as an example there, but not run.)

Otherwise, the code works fine with non-hierarchical models.

On Mon, Jun 7, 2021 at 3:54 PM Mine Dogucu @.***> wrote:

I am not getting any errors with prediction_summary_cv()?. I will look into classification_summary_cv()`

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mdogucu/bayesrules/issues/77#issuecomment-856250221, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDOVOT6BUHEUAKXHSCKBWLTRUWXTANCNFSM46HZJ5FQ .

-- Alicia Johnson she/her Associate Professor Mathematics, Statistics, and Computer Science Macalester College

mdogucu commented 3 years ago

Yeah, I tried it with running_model_1. Do you want to meet before Miles comes to debug together?