search

bayesiains / nflows

Normalizing flows in PyTorch
MIT License
849 stars 118 forks source link

Allow identity initialization for rational quadratic spline transform #65

Closed invemichele closed 1 year ago

invemichele commented 2 years ago

This PR implements what suggested in #50, adding a flag to ensure backward compatibility. I have been using it for quite some time now and I think it might be useful for someone else as well

invemichele commented 1 year ago

Our paper that uses this code has been accepted and will soon be published. It would be great if this PR could be merged, so that it would be easier for anyone to reproduce our results.

@arturbekasov is there anything you want me to add/change before merging?

arturbekasov commented 1 year ago

Sorry for the delay, @invemichele -- thanks a lot for taking the time to implement this.

LGTM in general, a nitpick: can we rename the parameter allow_identity_init to enable_identity_init?

invemichele commented 1 year ago

sure, no problem!

arturbekasov commented 1 year ago

Thank you very much, @invemichele!