search

bayesian-optimization / BayesianOptimization

A Python implementation of global optimization with gaussian processes.
https://bayesian-optimization.github.io/BayesianOptimization/index.html
MIT License
7.95k stars 1.55k forks source link

Update domain_reduction.py #454

Closed lm314 closed 10 months ago

lm314 commented 10 months ago

Adds ability to pass a dictionary as the minimum_window argument in SequentialDomainReductionTransformer. Deals with issue where TargetSpace sorts the pBounds dictionary, causing the order of the list used for minimum_window to possibly not match the order of the stored boundaries.

lm314 commented 10 months ago

Accidentally discarded changes from previous pull request, so resubmitting changes under a new pull request with most current version.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (844927b) 98.46% compared to head (ba6dc4f) 98.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #454 +/- ## ========================================== - Coverage 98.46% 98.38% -0.08% ========================================== Files 8 8 Lines 588 559 -29 Branches 88 85 -3 ========================================== - Hits 579 550 -29 Misses 3 3 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

till-m commented 10 months ago

LGTM. I don't really understand why coverage drops with this PR, but I don't think that should be a holdup for merging.

@bwheelz36 any idea?

If no objections, I will merge this soon.

till-m commented 10 months ago

Thanks for the contribution :)