bayesiancook / pbmpi

phylobayes mpi
GNU General Public License v2.0
23 stars 9 forks source link

Most, if not all, compilers warn about this. Perhaps a typo? #6

Closed bmcgough closed 6 years ago

bmcgough commented 6 years ago

https://github.com/bayesiancook/pbmpi/blob/e4ea1cae0026d2076bf3ec9cd4f09cf257015882/sources/GammaBranchProcess.cpp#L95

bayesiancook commented 6 years ago

thanks for the comment — no, not a typo: this is intended to return a log prob = - infinity (given the way the metropolis acceptance rule is implemented, this will indeed be accepted with probability 0)

best

Le 2 janv. 2018 à 23:17, Ben McGough notifications@github.com a écrit :

https://github.com/bayesiancook/pbmpi/blob/e4ea1cae0026d2076bf3ec9cd4f09cf257015882/sources/GammaBranchProcess.cpp#L95 https://github.com/bayesiancook/pbmpi/blob/e4ea1cae0026d2076bf3ec9cd4f09cf257015882/sources/GammaBranchProcess.cpp#L95 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bayesiancook/pbmpi/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AHwIoKSVhIC_DOwCdCofVykMRYTi9XgAks5tGqrigaJpZM4RRJGC.


Nicolas Lartillot Laboratoire Biométrie et Biologie Evolutive UMR CNRS 5558, Université Lyon 1 43 Bld du 11 Novembre 1918 69622 Villeurbanne cedex France

+33 (0)4 72 43 12 87

==================== The Bayesian kitchen http://bayesiancook.blogspot.fr/ a blog on statistical inference in evolutionary biology

bmcgough commented 6 years ago

Learning something new everyday!

[Future readers who may be confused as I was... floating point variables divided by 0 can produce negative or positive infinity. https://en.wikipedia.org/wiki/Extended_real_number_line]