search

bayesmix-dev / bayesmix

Flexible Bayesian nonparametric mixture models in C++
https://bayesmix.rtfd.io
BSD 3-Clause "New" or "Revised" License
22 stars 18 forks source link

Arbitrary delimiter in CSV I/O functions #109

Closed brunoguindani closed 2 years ago

brunoguindani commented 2 years ago

Automatic detection of delimiter is complicated, and would need a list of acceptable delimiters anyway, so I chose not to do it. Furthermore, the lack of it encourages usage of the correct delimiter, namely the comma. Multivariate CSV files have been modified accordingly.

Please rebase (😏) at will when you're done checking.

mberaha commented 2 years ago

Can you please check that also the bayesmixpy interface works ? :)

brunoguindani commented 2 years ago

Sure , which file should I run?

mberaha commented 2 years ago

Sure , which file should I run?

Any of the notebooks would be fine!

mberaha commented 2 years ago

Specifically, I am worried about the use of np.savetxt(data_file, data, fmt='%1.5f') and we might need to change that to comply with the new standard

brunoguindani commented 2 years ago

You're absolutely right, default delimiter for both np.savetxt and np.savetxt is space. (Why do you do that, numpy? I thought we were friends.) Now it's fixed. Both notebooks run fine.