Modifications needed for Pybmix

bayesmix-dev / bayesmix

Flexible Bayesian nonparametric mixture models in C++

https://bayesmix.rtfd.io

BSD 3-Clause "New" or "Revised" License

22 stars 18 forks source link

Modifications needed for Pybmix #136

Closed taguhiM closed 2 years ago

taguhiM commented 2 years ago

To wrap it up, the changes are:

using mersenne-twister 32bit engine instead of 64 to make it possible to synchronize the states with python
added python id for hierarchy and mixing
a small change in CMake, which was to solve tbb problem (as suggested by Mario in the discussions of the draft PR in pybmix)

mberaha commented 2 years ago

The conflict in docs/protos.html is happening because your fork is not up to date with our origin/master. Update the fork, pull locally and push again and it should be fine

taguhiM commented 2 years ago

Yeah, sorry, didn't notice that. Should be fine now.

brunoguindani commented 2 years ago

Sorry folks, I've been very busy. I will review this by tomorrow.