search

baykovr / AVPI

an open source voice command macro software
https://baykovr.github.io/gavpi.html
GNU General Public License v3.0
198 stars 42 forks source link

Call Application.Exit() on form close. #45

Closed AdamJamesNaylor closed 8 years ago

AdamJamesNaylor commented 8 years ago

I noticed the application wasn't terminating when I closed the form so I've added application.Exit() to the handler. Eventually this will need to be handle more appropriately but for now this has been tested and works locally.

AdamJamesNaylor commented 8 years ago

I just saw your conversation about the tray icon, this wasn't clear to me on first few runs. Maybe it needs to pop up the first few times you click close? I can add that behavior if agreed?

baykovr commented 8 years ago

@Simon-Dainty introduced a system tray feature on form close in https://github.com/baykovr/AVPI/commit/1b3b30b8e80b4c406fc47a06d07ac55e5eab51e6

When the form is closed the application actually resides in the system tray and continues running. This has caused confusion previously in https://github.com/baykovr/AVPI/issues/26

Perhaps we can add a dialog for "close" or "minimize to tray" options on form exit, what do you think?

baykovr commented 8 years ago

We think alike, I was typing that response before reading your follow up.

I agree with the pop up idea.

AdamJamesNaylor commented 8 years ago

Great I'll take a look at adding something to that affect.