search

bayleeadamoss / zazu-file-finder

A file finder for Zazu.
18 stars 11 forks source link

Fix issue with not being able to find apps on mac. #16

Closed bayleedev closed 7 years ago

bayleedev commented 7 years ago

Mac apps are .app and are also directories.

cc: @JeroenBoersma

JeroenBoersma commented 7 years ago

And on Linux they aren't :)

I've found something to suit both...

bayleedev commented 7 years ago

@JeroenBoersma what issue are you running into on linux? If on linux a directory can't be an app then I think it'll still be fine.

isDirectory isApp output
true true false
true false true
false true false
false false false
JeroenBoersma commented 7 years ago

Under Mac/Linux directories have execute rights to allow browsing so isApp will return true as isDirectory will too. Only Mac has it own logic for finding apps.

So, we will hit up the first line you describe true && false === false

JeroenBoersma commented 7 years ago

https://github.com/tinytacoteam/zazu-file-finder/pull/17 will help you out

bayleedev commented 7 years ago

Oh, I see what you're saying. I'll check out your pr now.

JeroenBoersma commented 7 years ago

Updated https://github.com/tinytacoteam/zazu-file-finder/pull/17