search

bayleeadamoss / zazu-file-finder

A file finder for Zazu.
18 stars 11 forks source link

Feature/adapter #28

Closed bayleedev closed 7 years ago

bayleedev commented 7 years ago

It might be easier to look at these commits separately.

I paired with @afaur on this.

reviewer: @twang2218

bayleedev commented 7 years ago

anybody free to look at this? @tinytacoteam/zazu-core

twang2218 commented 7 years ago

Although mdfind isn't slow, I think a cache database is still necessary, I tested this PR, and the App search on my macbook is slower than the master branch, the File search is faster and more powerful than master branch, however it still cost a minute or more to get the results back. But the cache database can be added later.

The adapter implementations looks good to me, I tested and it's working, I will merge it after the comment about the icon's location has been addressed.