Appearance of zazu window in Linux Mint 18 is plain without rounded corners or drop-shadow

pacharanero commented 7 years ago

Expected Behavior

From screenshots I've seen of Zazu on other platforms, the main search window has nice visual effects like rounded corners and drop-shadow.

Actual Behavior

On my machine the appearance is plain, without rounded corners or drop-shadow.

Steps to reproduce the behavior

1) Install Zazu on Linux Mint 18 2) Use the toggle key combination to launch the search window

Versions

Zazu: App Environment: production App Version: 0.3.2 Electron Version: 1.3.13 Node Version: 6.5.0 Chrome Version: 52.0.2743.82
OS: Linux Mint 18 x64 Cinnamon Dell Precision M3800 (notably this has a very high DPI screen so possibly this is something to do with it.

[Nice work on Zazu BTW. It's exactly what I have been looking for.]

I'd like to help fix this, I don't know much about Electron development but have done some reading and hacking with it before. Looking through the log files there doesn't seem to be any errors relating to the showWindow action or styling, but then again I'm not sure where failed styling errors might be shown (if at all)

bayleedev commented 7 years ago

This makes me a little sad.

Trying to figure out where I set those, they might be osx defaults for the app. It might be useful to try and add a border-radius to the themes that match. I'm not sure how to fix the drop shadow issue though.

pacharanero commented 7 years ago

Sorry it makes you sad Blaine. Zazu is pretty awesome other than this minor aesthetic issue. I'd tried Dext and some others but this is the first Linux launcher that I felt could displace Synapse from it's long-time home at ctrl + space. In fact I switched over from Synapse to Zazu just yesterday because it is easily as good as Synapse already. And because it's Electron & JS I can help make it better! (Synapse is written in Vala, which I couldn't even understand, never mind develop for)

I will have a look at the Electron docs and see if I can shed any light on how these features are set.

On 14 January 2017 at 16:24, Blaine Schmeisser notifications@github.com wrote:

This makes me a little sad.

Trying to figure out where I set those, they might be osx defaults for the app. It might be useful to try and add a border-radius to the themes that match. I'm not sure how to fix the drop shadow issue though.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tinytacoteam/zazu/issues/162#issuecomment-272634511, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVYcFJjh3hcSgpeW3bGCAADIMdMA3dks5rSPbLgaJpZM4LjgTL .

pacharanero commented 7 years ago

I think the lack of window shadow is a platform limitation in the Linux window manager's implementation of Electron. See this closed issue on the Electron github repo: https://github.com/electron/electron/issues/2380

charlesmilam commented 7 years ago

Does the theme being used for the desktop have any bearing on the appearance of Zazu? I am on Ubuntu 16.04 with Budgie desktop using the Adapta widget theme. I have drop shadows, but not rounded corners, but neither does the rest of my windows. Although on close inspection it does appear the other windows' corners are not as 'sharp' as Zazu's.

screenshot from 2017-01-15 14-21-59

cecoates commented 7 years ago

I'm on Debian Stretch, no special extras installed, and I have a drop shadow as well. It looks about the same to me between windows.

screenshot from 2017-01-15 15-48-01

I like the rectangle shape with sharp edges, personally. It's like, ENTER YOUR DATA HUMAN.

pacharanero commented 7 years ago

OK so perhaps this is an issue with Cinnamon rather than the X Window System?

On 15 January 2017 at 21:47, cecoates notifications@github.com wrote:

I'm on Debian Stretch, no special extras installed, and I have a drop shadow as well.

[image: screenshot from 2017-01-15 15-45-23] https://cloud.githubusercontent.com/assets/10121835/21966490/d25d57b2-db39-11e6-9328-0e04b3a05dfc.png

I like the rectangle shape with sharp edges, personally. It's like, ENTER YOUR DATA HUMAN.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tinytacoteam/zazu/issues/162#issuecomment-272726344, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVYZ75WcWGKQrOR8PZZ4dqMZHLHI8Qks5rSpPsgaJpZM4LjgTL .

pacharanero commented 7 years ago

I just tried Ubuntu 16.04 MATE in a VM and the window shadow is there, suggesting this issue is likely to be Cinnamon-related.

Window corners were not rounded though.