search

bayleeadamoss / zazu

:rocket: A fully extensible and open source launcher for hackers, creators and dabblers.
http://zazuapp.org
MIT License
2.09k stars 168 forks source link

Update node and fix search lag #320

Closed afaur closed 5 years ago

afaur commented 6 years ago

Currently when typing into the input of zazu there is a delay caused because a fn passed down through the many parent components.

When this fn is called (each time that the search component input detects a change) we currently determine which plugins have matched results and then additionally pass the new search input value back down to the search component.

This change will cut off the usage of the passed down search input value. It will instead set a local state value of searchQuery that at present isn't even bound to the value prop on the input (as I am unsure if it is actually needed?).

The other part of this work is the inclusion of a debounce on the handleQueryChange fn that will throttle the detection of which plugins matched when you type or remove characters in the input box.

I also included a node version bump to see if travis and appveyor is able to handle the latest node release.

linonetwo commented 5 years ago

The problem seems to be resolved in 0.6.0