Closed linonetwo closed 5 years ago
After this is merged, I'm going to fix some other issues.
But it becomes very slow after upgrade electron that many tests failed, I have to look into it.
Logging is very slow in electron5, even before I upgrade winston.
And it's all on globalEmitter.emit('pluginLog'
It's blazing fast because I only log when the debugger is opened.
But tests still failed, I'm confused.
Good, seems only some plugin regression remains.
I will look into it next weekend. It's hard to debug, since I can't run tests locally due to https://github.com/octalmage/robotjs/issues/483 . Considering replace robotjs with something actively maintained.
After upgrading cucumber, all test passed in Windows and Linux.
Reason for OSX failed maybe that spectron
is still on electron 3 https://github.com/electron/spectron/issues/358
And the reason of slow maybe https://github.com/catdad/raw-viewer/issues/142 May need to change the usage of fs to adapt sandbox https://electronjs.org/blog/electron-5-0#automatic-modules-with-sandboxed-webcontents
The reason why mac test fail is here https://github.com/garimpeiro-it/node-key-sender/issues/25
win.blur()
triggered by key-sender.
Now it pass all the test locally:
> cucumber-js --format ./features/support/custom_formattor.js
..................................................................................................................................................
17 scenarios (17 passed)
112 steps (112 passed)
5m30.139s
Fixing some plugin related regressions:
And dev dependencies:
After upgrading babel, seems can't directly require js files outside of app in the renderer process.
So I've changed all require('/user/xxx/pluginpath')
to electron.remote.require('/user/xxx/pluginpath')
.
This fixes all the failing tests.
And I did not properly ignore node_modules in @babel/register
, but it just worked in mac, but not in windows, so took me a lot of time to debug, until I use a virtual machine to see what actually happened.
@linonetwo so glad you picked this project up!
Reviewers don't have enough bandwidth for this recently, so I upload an upgraded version to baiducloud, only MacOS version:
https://pan.baidu.com/s/1aoScfago0PuGKJQtKYZEHQ password: krdd
And many plugins won't get an update recently, due to the lack of reviewer for PR. So I forked some of them and made them compatible for v0.6.0, here is my config file:
https://gist.github.com/linonetwo/c67997a192fd32df1211be5756c563e6
Latest electron contains Node version > 6, which can better supports some plugin (for example plugin that uses Wasm from sql.js)
Tested locally, functional properly, but seems lagging in dev build.