search

bayleedev / electron-notifications

:boom: A node module for sending notifications in electron applications.
MIT License
133 stars 54 forks source link

add optional notification duration #8

Closed koush closed 7 years ago

koush commented 8 years ago

my setInterval commit may be sketchy. I'm not sure the reasoning behind why it was implemented that way, but my commit is an alternative.

davidcoleman007 commented 7 years ago

Hi guys I need this functionality. Can this be merged please? Or possibly separate it into 2 pulls, since the .flat css is obviously not related to the working changes for duration? Thanks in advance! I can do the work if you guys don't have the time for it.

bayleedev commented 7 years ago

Deployed as v0.1.2

davidcoleman007 commented 7 years ago

Thank you guys!!!

davidcoleman007 commented 7 years ago

@blainesch I forked this repo last night and added some simple stacking logic too. feel free to check it out and let me know if it's something u want in the project. It (my stacking logic) could certainly be MUCH better, but it is what it is.

bayleedev commented 7 years ago

@davidcoleman007 I'm happy to merge in almost anything. PR's are appreciated :D

koush commented 7 years ago

@davidcoleman007 +1 on stacking.

davidcoleman007 commented 7 years ago

Hey guys, I'll make a pr from my fork tonight. It's nothing special but it's a step in the right direction.