baytechc / waasabi-config

Create and configure a new Waasabi instance
Other
0 stars 0 forks source link

Better handling of changed instance URLs #12

Closed flaki closed 3 years ago

flaki commented 3 years ago

A followup from #5, currently we always rebuild the local server & live page. With paid Ngrok plans supported, this might not be needed as the local servers could reuse the previously set server URL when reloading an existing configuration. We should check when this is the case and skip the rebuilding.

Probably the best way to implement this would be completely separating the "instance URL updated" event into its own function/module and ensuring we use it to update the URL of the Waasabi instance, whenever needed, and take care of any required rebuilding/restarts within this function.