search

bazaarvoice / cloudformation-ruby-dsl

Ruby DSL for creating Cloudformation templates
Apache License 2.0
210 stars 76 forks source link

Added a possibility to enable termination protection for stack creation only #132

Closed ssuprun closed 6 years ago

ssuprun commented 6 years ago

Since Amazon added the termination protection of CF stacks it makes sense to implement it here.

I've added this functionality to stack creation only. I believe, if we're going to protect our stack, this protection should be disabled manually only, so I see no any sense to change it in "update" method.

Protection can be enabled with option

--enable-termination-protection
thebearmayor commented 6 years ago

I'm confused by this, as I commented in the ticket. Extra options added to the commandline are passed on the cloudformation api call. The README says "Any other parameters are passed directly onto cloudformation. (--disable-rollback for instance)" and I've used this for --on-failure as well. So --enable-termination-protection should work already, assuming a new enough SDK.

ssuprun commented 6 years ago

Hey @thebearmayor . Yep, you're absolutely right. The most of these changes aren't needed. The one minor thing - we can update version of aws-sdk to the latest one... But current condition includes it for new installations. So I'm confirming that functionality works with the latest aws-sdk and removing this PR.