bazaarvoice / cloudformation-ruby-dsl

Ruby DSL for creating Cloudformation templates
Apache License 2.0
210 stars 76 forks source link

Updating AWS SDK to Version 3. #136

Open Noirbot opened 5 years ago

Noirbot commented 5 years ago

Description

Update the AWS-SDK to the new modular-ized version of the SDK. With V2, it requires you to install the sub-gems for every single AWS service, which can take quite a while, when we only need to install the S3 and Cloudformation ones.

For the purposes of this Gem, it seems like no actual code needs changing, since outside of the module-organization changes, the actual SDK is the same. I've tested this with a couple deployments, using S3 bucket uploads, and they worked, which seems to imply a lack of regressions in functionality between versions of the SDK.

In addition, I did some updates to our Gem docs, removing emails for folks who no longer have Bazaarvoice emails, and moving ownership to the BV team as a whole.

Steps to Test or Reproduce

In general, nothing should change functionally here, so to test it, you should just be able to link this PR's changes to the gemfile of an existing project, reinstall with Bundler, and check that it works.

You should also be able to see that there's many less dependencies being installed now.

# Gemfile to pull from local branch:
gem "cloudformation-ruby-dsl", path: "/PATH/TO/THIS/REPO/cloudformation-ruby-dsl"

Environment

You should be able to observe the benefit of AWS-SDK V3, and specifically the aws-sdk-cloudformation and aws-sdk-s3 modules alone.

Deploy Notes

This can probably just go out as a minor version update? There shouldn't be any breaking changes to the gem itself as a part of this.

Related Issues and PRs

None.

Todos

Request to Review

@jonaf @tianx2

wtfiwtz commented 4 years ago

gem install aws-sdk hangs for minutes. +1 for merging this 👍