bazaarvoice / cloudformation-ruby-dsl

Ruby DSL for creating Cloudformation templates
Apache License 2.0
210 stars 76 forks source link

Minify Json #16

Closed eschuchmann closed 10 years ago

eschuchmann commented 10 years ago
eschuchmann commented 10 years ago

Note: this PR has the side effect of no longer generating an expanded template file when running the expand command (this appeared to be a mistake, but some people might be relying on that behavior)

jonaf commented 10 years ago

This looks fine. Ideally we'd not have to add true to this and just use minify. We'll ignore the fact that minify might ordinarily also make changes like rename variables and functions, etc. I don't currently have any knowledge of a use-case where the expand sub-command is used to generate a JSON template file; but to restore that functionality if it is desired, a user can simply redirect stdout to a file.

For clarity, the primary motivation for this change is to allow for even larger CloudFormation templates.

shawnsmith commented 10 years ago

I think this needs to be updated so that diff is still useful since standard diff doesn't work well w/compact (non-pretty printed) json.