bazaarvoice / cloudformation-ruby-dsl

Ruby DSL for creating Cloudformation templates
Apache License 2.0
210 stars 76 forks source link

Separate the DSL code and the more specific code #47

Closed lethalpaga closed 9 years ago

lethalpaga commented 9 years ago

This moves all the generic DSL code in a separate file so that it can be used by other means than the provided cli + calls to cfn_cmd.

Note that although I was careful to make it backward-compatible for the end-users. it will probably cause merge conflicts for all the other active branches in github

jonaf commented 9 years ago

Hi @Lethalpaga, can you describe some use-cases for separating the DSL? Do you intend to use the DSL syntax for something other than Cloudformation?

temujin9 commented 9 years ago

@jonaf Actually, I can answer that. It's step 1 in reimplementing without the cfn_cmd dependency.

temujin9 commented 9 years ago

(Okay, in fairness: that's what it made me excited for. His motives may be different.)

temujin9 commented 9 years ago

Looks pretty good to us. We would certainly like to know your use cases for it, too.

Could you squash your commits (see Contributing docs)?

lethalpaga commented 9 years ago

All done :+1: (I've made a few small bugfixes since the last commit)

My main problem with the way it worked before was that it's really only meant to be run as an executable. That doesn't work for me because given the way my CI works I have to generate the template in a Rakefile, and :

So basically I needed a way to use the template DSL as a module, and the tight integration with cfn_cmd made that hard (that and I get a bit psycho when useful code gets heavily coupled with something I don't care about :stuck_out_tongue_winking_eye:) .