search

bazad / ida_kernelcache

An IDA Toolkit for analyzing iOS kernelcaches.
MIT License
284 stars 73 forks source link

IDA 7 fixes #3

Closed stek29 closed 6 years ago

bazad commented 6 years ago

Thanks for the new fixes! Do you know if these changes are compatible with IDA 6.95?

stek29 commented 6 years ago

@bazad No, sadly. And I can't really test it. However they should work, but I'm not sure about idc.OpStroffEx and idaapi.is_ident_char ones.

bazad commented 6 years ago

@stek29 I've tested the pull request and have a small change to reintroduce support for 6.95. I'd appreciate if you could test it again on IDA7 before I merge. Could you grant me push access to the ida7 branch and check if everything still works?

stek29 commented 6 years ago

@bazad how would I? "Allow edits from maintainers" is checked.

bazad commented 6 years ago

@stek29 Ah, sorry, I should have tried first. I've added the 6.95 fixes, let me know if it looks good.

stek29 commented 6 years ago

lgtm, would test in a couple of hours

stek29 commented 6 years ago

Sorry, forgot to respond -- it worked fine for me