search

bazel-contrib / SIG-rules-authors

Governance and admin for the rules authors Special Interest Group
https://bazel-contrib.github.io/SIG-rules-authors/
Apache License 2.0
28 stars 12 forks source link

Flip default for --incompatible_use_platforms_repo_for_constraints #43

Closed alexeagle closed 2 years ago

alexeagle commented 2 years ago

Help finish https://github.com/bazelbuild/bazel/issues/8622 by finding affected projects on Bazel CI and explicitly setting the flag to false, then land a PR in Bazel flipping the default value for new projects.

aiuto commented 2 years ago

This has someone in aiuto@'s team assigned to it.

alexeagle commented 2 years ago

@aiuto does that mean the SIG should not fund work on this? Should we close our issue?

aiuto commented 2 years ago

Exactly. @aranguyen is working on it.

cgrindel commented 2 years ago

@aranguyen Can you confirm whether this has been implemented?

I still see the flag in the latest doc.

aranguyen commented 2 years ago

@cgrindel yes this has been done but it probably hasn't made it to the most recent release. I submitted the change earlier today. I will update the doc separately. Thanks!

alexeagle commented 2 years ago

Was just flipped, caused breakages downstream: https://github.com/bazelbuild/continuous-integration/issues/1404 the team is working on it