bazel-contrib / SIG-rules-authors

Governance and admin for the rules authors Special Interest Group
https://bazel-contrib.github.io/SIG-rules-authors/
Apache License 2.0
28 stars 12 forks source link

Looks like rules-proto-grpc/rules_proto_grpc no longer supports java #90

Closed wcurrie closed 7 months ago

wcurrie commented 8 months ago

As of this commit https://github.com/rules-proto-grpc/rules_proto_grpc/commit/8b8dc50f090f1804c351a636134b3e480966c3f9, it looks like there's no support for java in rules-proto-grpc. Should the table here be updated?

image

There's no java listed here either

image

Maybe the rule from grpc-java should be mentioned instead?

From the discussion here, maybe the desired state isn't known yet:

Do you have a recommendation of which one?

cgrindel commented 8 months ago

Based upon this issue, it looks like they intend to support it. Since this seems related to the migration to bzlmod and java support is available on their legacy branch, I recommend that we not update the table.

wcurrie commented 7 months ago

Ah, so maybe the plan/thinking is java support back to the master branch after they work out how to add bzlmod support to grpc-java. That's probably what is explained in https://github.com/rules-proto-grpc/rules_proto_grpc/issues/269

Step 1 on this process will be a minimum viable module that maybe just supports a single language.

I'd not understood that sorry. It's currently a bit confusing since the generated rules-proto-grpc docs linked from the legacy branch (and served from googling) don't mention java right now

Full documentation for the current and previous versions can be found here

Thanks!

wcurrie commented 7 months ago

Noting for anybody else. On the docs site, there's a version toggle at the bottom. Switch off latest to see the docs about java

image

https://rules-proto-grpc.com/en/4.5.0/

And there's a note in the readme too

image