search

bazel-contrib / bazel-gazelle

Gazelle is a Bazel build file generator for Bazel projects. It natively supports Go and protobuf, and it may be extended to support new languages and custom rule sets.
Apache License 2.0
1.21k stars 381 forks source link

Add QNX and OSX to known platforms #1853

Closed hofbi closed 3 months ago

hofbi commented 4 months ago

What type of PR is this?

Uncomment one line below and remove others.

Bug fix

What package or component does this PR mostly affect?

language/go cmd/gazelle

What does this PR do? Why is it needed?

Adding more known platforms to avoid issue reported in https://github.com/bazelbuild/bazel-gazelle/issues/1735.

Which issues(s) does this PR fix?

Fixes #1735

Other notes for review

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

hofbi commented 3 months ago

@fmeum Could you take a look at this one?

darkrift commented 3 months ago

While working on another change in rules_go, I stumbled upon this PR because of the following error in our repository:

ERROR: /private/var/tmp/_bazel_rlavoie/a0035c26b826a3ecd42a2733d971df53/external/rules_go~/go/platform/BUILD.bazel: no such target '@@rules_go~//go/platform:osx': target 'osx' not declared in package 'go/platform' defined by /private/var/tmp/_bazel_rlavoie/a0035c26b826a3ecd42a2733d971df53/external/rules_go~/go/platform/BUILD.bazel
ERROR: /private/var/tmp/_bazel_rlavoie/a0035c26b826a3ecd42a2733d971df53/external/rules_go~/go/platform/BUILD.bazel: no such target '@@rules_go~//go/platform:qnx': target 'qnx' not declared in package 'go/platform' defined by /private/var/tmp/_bazel_rlavoie/a0035c26b826a3ecd42a2733d971df53/external/rules_go~/go/platform/BUILD.bazel
ERROR: /private/var/tmp/_bazel_rlavoie/a0035c26b826a3ecd42a2733d971df53/external/gazelle~~go_deps~com_github_prometheus_client_golang/prometheus/BUILD.bazel:3:11: errors encountered resolving select() keys for @@gazelle~~go_deps~com_github_prometheus_client_golang//prometheus:prometheus
ERROR: /private/var/tmp/_bazel_rlavoie/a0035c26b826a3ecd42a2733d971df53/external/gazelle~~go_deps~org_golang_google_grpc/internal/syscall/BUILD.bazel:3:11: errors encountered resolving select() keys for @@gazelle~~go_deps~org_golang_google_grpc//internal/syscall:syscall