search

bazel-contrib / bazel-gazelle

Gazelle is a Bazel build file generator for Bazel projects. It natively supports Go and protobuf, and it may be extended to support new languages and custom rule sets.
Apache License 2.0
1.19k stars 378 forks source link

Fix Issue #1855: "All Bazel commands fail when changing a Go dependency when using Bzlmod extension" #1861

Closed Buzz-Lightyear closed 2 months ago

Buzz-Lightyear commented 2 months ago

What type of PR is this? Bug fix

What package or component does this PR mostly affect? Go bzlmod

What does this PR do? Why is it needed? When trying to bump the version of a Go module in a repo that uses the go_deps bzlmod extension, we run into an issue wherein all Bazel commands fail with "Error in fail: No sum for <module>. However the suggested fix is to run bazel run @rules_go//go -- mod tidy which fails with the same error, thus forcing us into a pickle.

This PR changes this to a warning instead of an error after which the suggested fix works.

Which issues(s) does this PR fix?

Fixes #1855

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

stefanpenner commented 1 month ago

Thank you!