bazel-contrib / bazel-gazelle

Gazelle is a Bazel build file generator for Bazel projects. It natively supports Go and protobuf, and it may be extended to support new languages and custom rule sets.
Apache License 2.0
1.21k stars 381 forks source link

Don't call dict.pop() with named arguments #1951

Closed EdSchouten closed 1 month ago

EdSchouten commented 1 month ago

What type of PR is this?

Feature

What package or component does this PR mostly affect?

all

What does this PR do? Why is it needed?

I'm doing some experiments, where I'm trying to parse/analyze some existing Bazel rules using Go Starlark. This seems to be mostly successful, though I am noticing some small breakages.

Which issues(s) does this PR fix?

It fixes an issue where dict.pop() is called with named arguments in a couple of places, even though it's only supposed to be called with positional arguments.

Other notes for review