refactor: deprecated expand_locations which is just pass-through to ctx.expand_location() - Githubissues

bazel-contrib / bazel-lib

Common useful functions for writing BUILD files and Starlark macros/rules

Apache License 2.0

141 stars 91 forks source link

refactor: deprecated expand_locations which is just pass-through to ctx.expand_location() #910

Closed gregmagolan closed 3 months ago

gregmagolan commented 3 months ago

expand_locations is marked DEPRECATED since it now just calls ctx.expand_location(input, targets = targets). There was once a custom implementation but that was removed a while ago.

Changes are visible to end-users: yes

Searched for relevant documentation and updated as needed: yes
Breaking change (forces users to change their own code or config): no
Suggested release notes appear below: yes

expand_locations is marked DEPRECATED since it now just calls ctx.expand_location(input, targets = targets). There was once a custom implementation but that was removed a while ago.

Test plan

Covered by existing test cases

aspect-workflows[bot] commented 3 months ago

Test

All tests were cache hits

220 tests (100.0%) were fully cached saving 29s.

Test

e2e/copy_action

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.

Test

e2e/copy_to_directory

All tests were cache hits

6 tests (100.0%) were fully cached saving 750ms.

Test

e2e/coreutils

All tests were cache hits

4 tests (100.0%) were fully cached saving 742ms.

Test

e2e/external_copy_to_directory

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.

Test

e2e/smoke

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Buildifier Format Gazelle