search

bazel-contrib / bazel-lib

Common useful functions for writing BUILD files and Starlark macros/rules
Apache License 2.0
141 stars 91 forks source link

perf: Improve copy_file.bzl's progress_message and do some cleanup #931

Closed dzbarsky closed 2 months ago

dzbarsky commented 2 months ago

The change to progress_message saves around 100ms of analysis time for my big repo. The rest of the changes are cleanups to reflect that we have long since diverged from skylib's implementation.

jbedard commented 2 months ago

This code removal on its own seems worth it to me, but even more so for the perf win (even if small).

@alexeagle is an extra ../ (sometimes?) showing up in a progress message a big deal?