bazel-contrib / bazel_features

Support Bazel "feature detection" from starlark
https://docs.google.com/document/d/1HJf3gMYIrzmTRqbD4nWXH2eJRHXjLrOU0mmIeZplUzY/edit#heading=h.5mcn15i0e1ch
Apache License 2.0
19 stars 15 forks source link

Fix "same major version" check logic #52

Closed fmeum closed 7 months ago

fmeum commented 7 months ago

This was introduced in 2db269a, but unintentionally checked for full equality of major, minor and patch version rather than just the major version.

fmeum commented 7 months ago

FYI @dzbarsky

brentleyjones commented 7 months ago

Do we want a unit test? 😅

fmeum commented 7 months ago

Do we want a unit test? 😅

We do, but it's also pretty difficult to write one with the current setup. I will keep a mental note to refactor this logic now that we have more complex operators.

timothyg-stripe commented 7 months ago

Oops, thank you!