search

bazel-contrib / bazel_features

Support Bazel "feature detection" from starlark
https://docs.google.com/document/d/1HJf3gMYIrzmTRqbD4nWXH2eJRHXjLrOU0mmIeZplUzY/edit#heading=h.5mcn15i0e1ch
Apache License 2.0
19 stars 15 forks source link

Make deps target public #62

Closed illicitonion closed 3 months ago

illicitonion commented 3 months ago

rules_rust depends on this, and our stardoc build is sad if we don't have a dep on it.

illicitonion commented 3 months ago

If I could bother a maintainer for a release if/when this merges, that'd be handy, thanks!

fmeum commented 3 months ago

I can't create releases at the moment, @meteorcloudy could you?

meteorcloudy commented 3 months ago

I'll be occupied for the next 2 hours, @Wyverald can you help?

Wyverald commented 3 months ago

Done. Waiting for publish-to-bcr now

fmeum commented 3 months ago

The BCR release failed to access the release archive with a 404. We need to release again.

Wyverald commented 3 months ago

https://github.com/bazelbuild/bazel-central-registry/pull/2438

meteorcloudy commented 3 months ago

The BCR release failed to access the release archive with a 404. We need to release again.

Was that a bug in the publish-to-bcr bot or the release process?

fmeum commented 3 months ago

Since the same process worked on the re-release, I would say it was a GitHub outage. I saw similar failures in other CI pipelines.

meteorcloudy commented 3 months ago

Ah, thanks for the context!

meteorcloudy commented 3 months ago

@kormide Any easy way to retrigger publish-to-bcr in such cases? Does it work if we change the release to a prerelease and back?

Wyverald commented 3 months ago

Since the same process worked on the re-release, I would say it was a GitHub outage. I saw similar failures in other CI pipelines.

I didn't do a re-release; I created the BCR PR myself.

I wonder if it's a race condition between the hook to "upload release archive on release" and "publish-to-BCR on release". Maybe we could simply have publish-to-bcr retry with some long backoff on a 404. See also https://bazelbuild.slack.com/archives/C014RARENH0/p1720549041765859?thread_ts=1720549041.765859&cid=C014RARENH0

kormide commented 3 months ago

@kormide Any easy way to retrigger publish-to-bcr in such cases? Does it work if we change the release to a prerelease and back?

The only way to retrigger it currently is to delete then re-create the release. This will change in the next quarter or so as we migrate it to a GitHub Action to support provenance; you'll have more manual control over re-running it.

I wonder if it's a race condition between the hook to "upload release archive on release" and "publish-to-BCR on release". Maybe we could simply have publish-to-bcr retry with some long backoff on a 404. See also https://bazelbuild.slack.com/archives/C014RARENH0/p1720549041765859?thread_ts=1720549041.765859&cid=C014RARENH0

Publish To BCR does do retries with backoff, however it's recommended that you upload the release archive as part of publishing the release rather than uploading it afterward to avoid race conditions.