bazel-contrib / bcr-ui

Website for the Bazel Central Registry
https://registry.bazel.build
Apache License 2.0
17 stars 8 forks source link

Implement proper version sorting #148

Closed Wyverald closed 2 months ago

Wyverald commented 3 months ago

Got bored and wanted to explore Typescript.

Tested on https://typescriptlang.org/play:

> console.log(sortVersions(['1.2.3', '1.2.3-d', '1.2.3.bcr.1', '1.2.3rc3', '1', 'k']))
["k", "1.2.3rc3", "1.2.3.bcr.1", "1.2.3", "1.2.3-d", "1"] 

Partially addresses #54.

Fixes #142.

Wyverald commented 3 months ago

gentle ping @hobofan

meteorcloudy commented 2 months ago

Can you pleas check


Run pnpm prettier-check

> bcr-web-ui@0.1.0 prettier-check /home/runner/work/bcr-ui/bcr-ui
> prettier --check .

Checking formatting...
[warn] data/moduleStaticProps.ts
[warn] Code style issues found in the above file. Run Prettier to fix.
 ELIFECYCLE  Command failed with exit code 1.
 ```
Wyverald commented 2 months ago

Fixed!