bazel-contrib / bcr-ui

Website for the Bazel Central Registry
https://registry.bazel.build
Apache License 2.0
15 stars 8 forks source link

Add icons for docs and contribute links #45

Closed hanneskaeufler closed 1 year ago

hanneskaeufler commented 1 year ago

Makes the page slightly more interesting to look at.

Bildschirm­foto 2023-01-06 um 16 27 53
hobofan commented 1 year ago

Hmm, I personally have neutral opinions on that change.

However, I know that the Bazel team was interested with harmonizing the design of registry.bazel.build with the one used under bazel.build (https://github.com/bazelbuild/bazel-central-registry/issues/137), and I feel like this might go counter to that. @meteorcloudy ?

hanneskaeufler commented 1 year ago

Yeah I saw that issue after making that change. I feel like until that visual alignment happens, this makes it slightly nicer. But feel free to decide either way. Thanks for looking at the change :)

meteorcloudy commented 1 year ago

@philomathing What do you think? Can you provide any style guide and resources so that the community can help better align registry.bazel.build with the Bazel DevSite?

philomathing commented 1 year ago

Unfortunately, I can't prioritize making a style guide thiq quarter. However, the assets from bazel.build are already in this deck https://docs.google.com/presentation/d/19zSuGlzb9s6C0RSE_TTVZdD6UnYelRtwe83shUG3Q5A/edit#slide=id.g135a463ca5d_0_19 and colors can be picked from the site using the Inspect tool in-browser. Will that work?

Lyra

On Tue, Jan 10, 2023 at 6:48 AM Yun Peng @.***> wrote:

@philomathing https://github.com/philomathing What do you think? Can you provide any style guide and resources so that the community can help better align registry.bazel.build with the Bazel DevSite?

— Reply to this email directly, view it on GitHub https://github.com/bazel-contrib/bcr-ui/pull/45#issuecomment-1377390678, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARQY73V2HXWHEYA5U3YYO5LWRVZEPANCNFSM6AAAAAATTF62PY . You are receiving this because you were mentioned.Message ID: @.***>

--

Lyra Levin | Writer | @.***

Have thoughts about working with me? go/philomath-feedback