bazel-contrib / bcr-ui

Website for the Bazel Central Registry
https://registry.bazel.build
Apache License 2.0
15 stars 8 forks source link

Fix broken link to release notes #49

Closed hanneskaeufler closed 1 year ago

hanneskaeufler commented 1 year ago

GitHub's urls to the releases are not prefixed with v. All those links in the registry are 404s currently.

hanneskaeufler commented 1 year ago

GitHub's urls to the releases are not prefixed with v. All those links in the registry are 404s currently.

Ah that's annoying, that ... depends on the tag name. Current link is good for e.g. https://github.com/aspect-build/bazel-lib/releases/tag/v1.19.2

Not sure what to do about this then ... I don't suppose we have any information on the git tag name.

alexeagle commented 1 year ago

Yeah, see https://github.com/bazel-contrib/bcr-ui/pull/37#issuecomment-1378131591 for more discussion of this. One "right" answer is to add more to the upstream metadata.json provided by ruleset in the BCR saying what their tagging scheme is.