Hotfix version parsing breaking build by ignoring non-semver

bazel-contrib / bcr-ui

Website for the Bazel Central Registry

https://registry.bazel.build

Apache License 2.0

15 stars 8 forks source link

Hotfix version parsing breaking build by ignoring non-semver #55

Closed hobofan closed 1 year ago

hobofan commented 1 year ago

FIXES #54

Bump compare-versions to latest version
Split out versions that are non-semver compliant before sorting for the time being

alexeagle commented 1 year ago

@hobofan I think this got the sorting backwards. https://registry.bazel.build/modules/rules_python is suggesting to copy-paste a snippet that gives 0.4.0 while the latest is 0.18.1

hobofan commented 1 year ago

@alexeagle Ah damn, you are right. When going to the non-versioned page it also picks the oldest version as the latest version. I tried to straighten out the sorting, but looks like I missed that part.

Will open a PR ASAP.

alexeagle commented 1 year ago

Ping on this @hobofan

seh commented 1 year ago

This came up today in the "bzlmod" channel of the "Bazel" Slack workspace.