search

bazel-contrib / rules-template

A template for creating a new Bazel ruleset
Apache License 2.0
78 stars 20 forks source link

chore: break out a reusable GitHub Actions workflow #58

Closed alexeagle closed 1 year ago

alexeagle commented 1 year ago

This will allow downstream forked repos to get improvements to the copy they got from here.

alexeagle commented 1 year ago

Example usage downstream: https://github.com/aspect-build/rules_jasmine/pull/50

alexeagle commented 1 year ago

I guess it's not desirable that you end up with a copy of the reusable workflow in a repo that's stamped out from this template, so there ought to be a separate repository under bazel-contrib that has the reusable workflow file and gets tagged.

Technically it could go in https://github.com/bazel-contrib/.github but it seems strange for that repo to be tagged. I could make a new repo, but I wish we wouldn't have the overhead of configuring one just for a single file. We could use some other repo like SIG-rules-authors, but it seems a waste for users to clone that whole thing to get a single file.

kormide commented 1 year ago

I guess it's not desirable that you end up with a copy of the reusable workflow in a repo that's stamped out from this template, so there ought to be a separate repository under bazel-contrib that has the reusable workflow file and gets tagged.

I'm not quite following this. It's not desirable to get this workflows ci template?

alexeagle commented 1 year ago

@kormide the idea is that the reusable workflow is centrally updated, so every repo doesn't end up having to maintain a forked copy of it.