search

bazel-contrib / rules_bazel_integration_test

Rules and macros for executing integration tests that use Bazel. Supports running integration tests with multiple versions of Bazel.
Apache License 2.0
46 stars 9 forks source link

Tests fail on windows with 'FINDSTR: /= ignored' #331

Open peakschris opened 3 months ago

peakschris commented 3 months ago

Around 45 tests in this repo are failing on windows with what looks like the same underlying issue:

INFO: From Testing //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest:
==================== Test output for //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest:
FINDSTR: /= ignored
FINDSTR: /" ignored
FINDSTR: /= ignored
FINDSTR: /" ignored
FAIL: files "bazel_integration_test/private/no_deps_utils.bzl" and "bazel_integration_test/private/no_deps_utils.bzl.formatted" differ.
================================================================================

To reproduce, windows 10:

git clone
cd rules_bazel_integration_test
bazel test //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest
bazel clean
bazel --windows_enable_symlinks test //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest
bazel clean
bazel --windows_enable_symlinks test //bazel_integration_test/private:bzlformat_no_deps_utils_bzl_fmttest --enable_runfiles

At a minimum I believe the last invocation should be supported.

I can contribute a fix to this, if it would help.

cgrindel commented 3 months ago

I marked this as an enhancement as it is adding Windows support. Thanks for the contributions!