search

bazel-contrib / rules_bazel_integration_test

Rules and macros for executing integration tests that use Bazel. Supports running integration tests with multiple versions of Bazel.
Apache License 2.0
39 stars 7 forks source link

fix: windows functionality and tests #334

Closed peakschris closed 2 days ago

peakschris commented 6 days ago

There are four issues when running on windows:

  1. https://github.com/bazel-contrib/rules_bazel_integration_test/issues/330
  2. https://github.com/bazel-contrib/rules_bazel_integration_test/issues/331
  3. https://github.com/bazel-contrib/rules_bazel_integration_test/issues/332
  4. https://github.com/bazel-contrib/rules_bazel_integration_test/issues/333

This PR fixes 3 and 4.

There are related PRs in bazel-skylib and bazel-starlib. There is no dependency -- the PRs can close in any order.

Test results:

Before: --enable_runfiles: 0 pass --noenable_runfiles: 0 pass

After this PR: --enable_runfiles: 52 pass, 19 failures --noenable_runfiles: 51 pass, 20 failures (17 are doc diff-tests due to bazel-starlib)

After this PR, together with wip PRs for 1 and 2: --enable_runfiles: 71 pass, 0 failures --noenable_runfiles: 51 pass, 20 failures (all due to bazel-starlib)

peakschris commented 4 days ago

I've updated this PR, could someone please approve the CI workflow?

cgrindel commented 4 days ago

I approved the CI.