search

bazel-contrib / rules_foreign_cc

Build rules for interfacing with "foreign" (non-Bazel) build systems (CMake, configure-make, GNU Make, boost, ninja, Meson)
https://bazel-contrib.github.io/rules_foreign_cc
Apache License 2.0
680 stars 249 forks source link

Fix - Copy Dir ignores hidden files on macOS #1188

Closed LaurenceTews closed 7 months ago

LaurenceTews commented 8 months ago

The copy_dir_contents_to_dir command currently ignores hidden files (e.g. dotfiles), leading to missing files after copying. Removing the * character in this case maintains the same behaviour, only with the inclusion of hidden files (.clang-tidy, .gitignore, etc).

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.