bazel-contrib / rules_foreign_cc

Build rules for interfacing with "foreign" (non-Bazel) build systems (CMake, configure-make, GNU Make, boost, ninja, Meson)
https://bazel-contrib.github.io/rules_foreign_cc
Apache License 2.0
680 stars 249 forks source link

Fix compatibility with `--incompatible_sandbox_hermetic_tmp` #1196

Open thii opened 7 months ago

thii commented 7 months ago

Instead of only replacing symlinks of declared output files, now we need to replace symlinks of everything in the declared tree artifact. Without this, Bazel 7 would fail when it verifies the tree artifact contents, which would contain dangling symlinks when building with --incompatible_sandbox_hermetic_tmp.

Fixes https://github.com/bazelbuild/rules_foreign_cc/issues/1129