search

bazel-contrib / rules_foreign_cc

Build rules for interfacing with "foreign" (non-Bazel) build systems (CMake, configure-make, GNU Make, boost, ninja, Meson)
https://bazel-contrib.github.io/rules_foreign_cc
Apache License 2.0
680 stars 249 forks source link

Fix pkgconfig_build.bzl for Windows build with Bzlmod #1241

Open meteorcloudy opened 3 months ago

meteorcloudy commented 3 months ago

Make sure repo names are generated correctly and toolchain label is passed instead of pure string.

Hopefully fixes https://github.com/bazelbuild/rules_foreign_cc/issues/1239

jsharpe commented 3 months ago

We might want to actually enable bzlmod in CI for windows to test this!: https://github.com/bazelbuild/rules_foreign_cc/blob/fb209674f326b7020f64d5d022cbe7fa16f3209c/.bazelci/config.yaml#L31

jsharpe commented 3 months ago

Just updating to latest main to get a clearer idea of what's broken in CI