bazel-contrib / rules_foreign_cc

Build rules for interfacing with "foreign" (non-Bazel) build systems (CMake, configure-make, GNU Make, boost, ninja, Meson)
https://bazel-contrib.github.io/rules_foreign_cc
Apache License 2.0
680 stars 249 forks source link

correct overeager slash conversion on windows #1285

Closed novas0x2a closed 3 weeks ago

novas0x2a commented 2 months ago

Bazel's File().path method will return forward-slashed paths; this means if you pass a flag like "/FI" + f.path it'll end up looking like /FIpath/to/thing; however, _convert_flags was converting all / to -, which ended up breaking the path. This makes sure to only replace the first /.

novas0x2a commented 1 month ago

ping @jsharpe :)